Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLCKCHN-141] optimise client params, sync it up with server #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yeehan-crypto-com
Copy link
Collaborator

@yeehan-crypto-com yeehan-crypto-com commented Oct 8, 2024

Pull Request Template

Description

Parent: BLCKCHN-100
Ticket: BLCKCHN-141

  1. Add context to the client params
  2. Update client params to match server (only require explorer API keys and chainID

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before you submit the pull request, please review the following checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Linked Issues

Mention the issues that are addressed by this PR. You can use the # symbol to link an issue.

@yeehan-crypto-com yeehan-crypto-com changed the title optimise client params, sync it up with server [BLCKCHN-141] optimise client params, sync it up with server Oct 8, 2024
Copy link

@leejw51crypto leejw51crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants